search

hsyyid / Kits

A Kits Plugin for Sponge!
4 stars 3 forks source link

I swear to Allmighty Hassan #6

Open Darktilldawn opened 8 years ago

Darktilldawn commented 8 years ago

http://pastebin.com/twEuWMPz

Do something xD started not saving the data again, causing lag. And shit ton of tmp files.

hsyyid commented 8 years ago

AccessDeniedException... :cry:

ryantheleach commented 8 years ago

https://github.com/hsyyid/Kits/blob/master/src/main/java/io/github/hsyyid/kits/config/PlayerDataConfig.java#L30

Why do you add a Path to a String? you are relying on potentially changing toString behaviour.

Paths.get(Kits.getKits().getConfigDir().resolve("data") + "/playerdata.conf"); -> Kits.getKits().getConfigDir().resolve("data").resolve("playerdata.conf");

or at least fix it to

Paths.get(Kits.getKits().getConfigDir().resolve("data/playerdata.conf"));

hsyyid commented 8 years ago

@ryantheleach Okay, but I don't see how that relates to this issue?

ryantheleach commented 8 years ago

I was looking through your code trying to find spots that could potentially be causing this bug. As I believe my own instance was user error.