Reconsider rounding in outputs and reporting tables - Githubissues

hta-pharma / maicplus

open source R package for MAIC

https://hta-pharma.github.io/maicplus/

2 stars 1 forks source link

Reconsider rounding in outputs and reporting tables #101

Open gravesti opened 4 months ago

gravesti commented 4 months ago

Consider R/maic_unanchored.R around #422 eg tmp_report_table_binary <- paste0(format(round(..., 2), nsmall = 2)

          Digits is fixed to 2. If user wants 3 digits, there's no way to retrieve it.

Can you return the original calculated confidence interval/standard error i.e. boot_res_AB and res_AB

_Originally posted by @MikeJSeo in https://github.com/hta-pharma/maicplus/pull/93#discussion_r1598365229_

[ ] review "raw" calculated values, including CI and p-values, tests
[ ] classes for list of wrapper function output = "raw" values
[ ] print methods for nice printing of raw values
[ ] summary methods for rounding and formatting for reports

gravesti commented 2 months ago

@hoppanda @MikeJSeo To review raw format and printed/summary format:

estimate, sd, var, ci upper, ci lower
remove p-values in bootstrap?
- Only report p-values where they are correct, consistent and meaningful!
- Describe which test the p-value comes from