hta-pharma / maicplus

open source R package for MAIC
https://hta-pharma.github.io/maicplus/
2 stars 1 forks source link

Control optim printing #106

Closed gravesti closed 5 months ago

gravesti commented 5 months ago

This PR allows us to give arguments directly to optim control, so we can change the trace and number of iterations. Setting trace = 0 stops all printing. I also added a warning when optim doesn't converge.

github-actions[bot] commented 5 months ago

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------
R/binary-helper.R         59       7  88.14%   14, 18, 21, 24, 28, 31, 36
R/bootstrap.R             23      23  0.00%    54-88
R/bucher.R                50       4  92.00%   49, 97, 101, 105
R/data_generation.R       20      20  0.00%    36-73
R/maic_anchored.R        140      32  77.14%   62-69, 74-77, 81, 84, 88, 91-94, 97-100, 105-106, 110, 113, 134-139, 156
R/maic_unanchored.R      251      40  84.06%   79-86, 89-90, 95, 98-101, 104-107, 112, 122, 125, 147-154, 183, 276-277, 344-348, 376-377, 409-410
R/matching.R             246     144  41.46%   60, 67, 72-75, 82-89, 110, 169, 209, 251-513
R/plot_km.R              449     373  16.93%   46-598
R/plot_km2.R             107     107  0.00%    50-209
R/process_data.R         101      44  56.44%   49-51, 56, 71-74, 80, 92-93, 183, 216-280
R/reporting.R             59       1  98.31%   91
R/survival-helper.R       30       3  90.00%   63, 66-67
R/time-helper.R            9       4  55.56%   22, 37-38, 52
R/zzz.R                    1       1  0.00%    2
TOTAL                   1545     803  48.03%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/matching.R       +6       0  +1.46%
TOTAL              +6       0  +0.20%

Results for commit: 445c5d51e4ff5a11958a6b31b063fe4ffe123d5d

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 5 months ago

Unit Tests Summary

 1 files   6 suites   4s :stopwatch: 18 tests 18 :white_check_mark: 0 :zzz: 0 :x: 52 runs  52 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 445c5d51.

github-actions[bot] commented 5 months ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | matching | 👶 | | $+0.01$ | estimate_weights_prints_errors_about_convergence |

Results for commit 3f54ece18243a153a64aca859308ebd31b3ce6a5

♻️ This comment has been updated with latest results.