hta-pharma / maicplus

open source R package for MAIC
https://hta-pharma.github.io/maicplus/
2 stars 1 forks source link

152 normalize weights update #153

Closed MikeJSeo closed 2 weeks ago

github-actions[bot] commented 2 weeks ago

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------
R/binary-helper.R         72       7  90.28%   14, 18, 21, 24, 28, 31, 36
R/bucher.R                62       5  91.94%   103, 107, 111, 186-187
R/maic_anchored.R        499      52  89.58%   93-100, 105-108, 112, 115, 119, 122-125, 128-131, 136, 141, 144, 157, 166-171, 226, 306, 312, 317-321, 554, 560, 565-569, 677-682
R/maic_unanchored.R      301      39  87.04%   85-92, 95-96, 101, 104-107, 110-113, 118, 127, 130, 143, 157-164, 193, 259, 266, 268, 403-405, 414, 421, 423
R/matching.R             251     146  41.83%   68, 73-75, 80-83, 90-93, 104, 131, 152, 188, 227, 276-546
R/plot_km.R              449      46  89.76%   56, 59, 62, 81-111, 302, 305-307, 322-325, 357, 413, 493, 496, 499, 511-512
R/plot_km2.R             109      23  78.90%   53, 62, 65, 68, 77, 94-100, 127-135, 138, 185
R/process_data.R         101      55  45.54%   38-40, 45, 60-63, 69, 81-82, 113-124, 162, 195-260
R/reporting.R             59      59  0.00%    14-111
R/survival-helper.R       30       1  96.67%   61
R/time-helper.R           20       3  85.00%   31, 57-58
R/utils.R                 24       9  62.50%   11-20
R/zzz.R                    1       1  0.00%    2
TOTAL                   1978     446  77.45%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/plot_km2.R       +2      +1  -0.54%
TOTAL              +2      +1  -0.03%

Results for commit: 791b88417d04df04e79075448ec73923d83164c7

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 2 weeks ago

Unit Tests Summary

  1 files   9 suites   6s :stopwatch:  32 tests 32 :white_check_mark: 0 :zzz: 0 :x: 104 runs  95 :white_check_mark: 9 :zzz: 0 :x:

Results for commit 791b8841.

:recycle: This comment has been updated with latest results.

MikeJSeo commented 2 weeks ago

Test on what? @gravesti :)

gravesti commented 2 weeks ago

That the function produces the right plot if you have normalize weight = TRUE or FALSE

github-actions[bot] commented 2 weeks ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | plot_km | 👶 | | $+0.12$ | kmplot_normalize_weights_works |

Results for commit 8c2ac25b49b5167bc59962b19e53e268a5f9567d

♻️ This comment has been updated with latest results.

MikeJSeo commented 2 weeks ago

Checks passed :)