class '.close' of bootstrap breaks layout of code snippets when you use _close.scss of Bootstrap.

htanjo / kss-node-template

Stylish template for kss-node.

http://htanjo.github.io/kss-node-template/

MIT License

62 stars 28 forks source link

class '.close' of bootstrap breaks layout of code snippets when you use _close.scss of Bootstrap. #7

Open Mishurin opened 9 years ago

Mishurin commented 9 years ago

I think, it is reasonable to add some styles for .close class since it is used for styling in rainbow. For example, .rainbow { .close { float: none; font-size: inherit; font-weight: inherit; line-height: inherit; text-shadow: none; opacity: 1; filter: none; &:hover, &:focus { color: inherit; text-decoration: inherit; cursor: inherit; opacity: 1; } } } This means, that in scope of .rainbow we have defined styles for .close class.

Mishurin commented 9 years ago

Otherwise you will get broken html code examples as I got.

htanjo commented 9 years ago

Thank you for reporting! Actually we can prevent the layout issue by overriding with .rainbow .close { ... }, but I don't think it's perfect. (see: https://github.com/ccampbell/rainbow/issues/101)

I'm planning to switch the syntax highlighting library itself. I will choose a new library that uses high compatibility class names, like .some-prefix-close.