htczion / ZKMA

Zion Key Management Api
Other
37 stars 15 forks source link

Document argument rates of SignTransaction #2

Open mikeshultz opened 4 years ago

mikeshultz commented 4 years ago

The argument float rates of the following function is not documented:

https://github.com/htczion/ZKMA/blob/92665e080e9c5518e581e19b4db422ee2ae962b7/HtcWalletSDK/src/main/java/com/htc/htcwalletsdk/Security/Core/TEEKHelper.java#L477

What is this supposed to be, exactly? It's not mentioned in the wiki at all and not documented in the code.

hawkwei0921 commented 4 years ago

Hi Mike, The rate parameter is USD currency rate. I will update wiki about this part.

Thanks for your advice! Hawk

/**

Hawk Wei

M: +886 (0)952183055 T: +886 (0)2 8912 4138 ext.(4710)23580

88 Section 3, Zhongxing Road, Xindian District, New Taipei City 231, Taiwan www.htc.com


寄件者: Mike Shultz notifications@github.com 寄件日期: 2020年9月2日 上午 05:27 收件者: htczion/ZKMA ZKMA@noreply.github.com 副本: Subscribed subscribed@noreply.github.com 主旨: [htczion/ZKMA] Document argument rates of SignTransaction (#2)

The argument float rates of the following function is not documented:

https://github.com/htczion/ZKMA/blob/92665e080e9c5518e581e19b4db422ee2ae962b7/HtcWalletSDK/src/main/java/com/htc/htcwalletsdk/Security/Core/TEEKHelper.java#L477

What is this supposed to be, exactly? It's not mentioned in the wiki at all and not documented in the code.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/htczion/ZKMA/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMCDRQMXY7RVGTJILM3VSWLSDVRNHANCNFSM4QSHNCIQ. CONFIDENTIALITY NOTE : The information in this e-mail is confidential and privileged; it is intended for use solely by the individual or entity named as the recipient hereof. Disclosure, copying, distribution, or use of the contents of this e-mail by persons other than the intended recipient is strictly prohibited and may violate applicable laws. If you have received this e-mail in error, please delete the original message and notify us by return email or collect call immediately. Thank you. HTC Corporation