search

htgt / CRISPR-Analyser

C++ package for analysing CRISPR off targets
MIT License
21 stars 8 forks source link

can crash ots_server with invalid id #7

Open gbeane opened 8 years ago

gbeane commented 8 years ago

It is possible to crash ots_server by doing a off_target query and providing an id with invalid characters:

for example passing a non-integer as an id: http://my_server:8080/api/off_targets?ids=xyz&species=Mouse

results in a core dump:

terminate called after throwing an instance of 'std::invalid_argument' what(): stoull Aborted (core dumped)

dparrysmith commented 8 years ago

Hi Glen,

Thanks for your bug report. We will endeavour to fix it in a future release. Alternatively if you have code that’ll fix this problem please let us know so that it can be icorporated.

Regards,

David

On 2 Mar 2016, at 19:07, Glen Beane notifications@github.com wrote:

It is possible to crash ots_server by doing a off_target query and providing an id with invalid characters:

for example passing a non-integer as an id: http://my_server:8080/api/off_targets?ids=xyz&species=Mouse

results in a core dump:

terminate called after throwing an instance of 'std::invalid_argument' what(): stoull Aborted (core dumped)

— Reply to this email directly or view it on GitHub https://github.com/htgt/CRISPR-Analyser/issues/7.

The Wellcome Trust Sanger Institute is operated by Genome Research Limited, a charity registered in England with number 1021457 and a company registered in England with number 2742969, whose registered office is 215 Euston Road, London, NW1 2BE.