search

hthiery / python-fritzhome

Python Library to access AVM Fritz!Box homeautomation
MIT License
52 stars 37 forks source link

please do release 0.6.6 #67

Closed mib1185 closed 2 years ago

mib1185 commented 2 years ago

Hi @hthiery may I ask to do a new release (0.6.6)? I would to go further with some open tasks for the Fritz!Smarthome integration in home-assistant. thanks in advanced. Regards, Michael

hthiery commented 2 years ago

just pushed the tag

hthiery commented 2 years ago

unfortunatly the publishing to pypi did not work. Currently I have no time to fix that ... I can do that maybe later. if you are interested in take a look on that feal free.

mib1185 commented 2 years ago

you forgot to bump the version in setup.cfg, too.

AlexKay88 commented 2 years ago

Thanks to both of you for follow up and progress!

@mib1185 Just a reminder to reverse https://github.com/home-assistant/core/pull/73608 after https://github.com/hthiery/python-fritzhome/pull/64 is included in new release 0.6.6. Sorry to mention here, but the PR and other conversations "... has been locked and limited to collaborators" so that I can't update there.

mib1185 commented 2 years ago

@AlexKay88 exactly this was my intention, why i asked for a release 😉

hthiery commented 2 years ago

I had to create a 0.6.7 release. It is now available on pypi.

sevorl commented 2 years ago

This is very off-topic, but: @mib1185 , are you maintaining the home-assistant integration for Fritz!SmartHome?

It would be so great if the Fritz!SmartHome integration would implement the "Set window open" service, which is already available in python-fritzhome.

hthiery commented 2 years ago

@mib1185 could you test the released version?

mib1185 commented 2 years ago

@hthiery will do the test later, afterwards will add the new lib version to HA. Thanks for your efforts 👍

flabbamann commented 2 years ago

I had to create a 0.6.7 release. It is now available on pypi.

Please don't forget to push the version bump to master. Thank you 👍

mib1185 commented 2 years ago
mib1185 commented 2 years ago

This is very off-topic, but: @mib1185 , are you maintaining the home-assistant integration for Fritz!SmartHome?

It would be so great if the Fritz!SmartHome integration would implement the "Set window open" service, which is already available in python-fritzhome.

@sevorl this is actually support since 2022.9 (see home-assistant/core/pull/76386)

sevorl commented 2 years ago

@mib1185 , set window open is about the „window open detection“ in fritz thermostats, to turn of the heater when a window was opened, not about a window cover. So I don’t think this is supported yet in home assistant.

mib1185 commented 2 years ago

@mib1185 , set window open is about the „window open detection“ in fritz thermostats, to turn of the heater when a window was opened, not about a window cover. So I don’t think this is supported yet in home assistant.

ah ok ... this is not a "default" service for a climate entity in HA, so it would need "a bit more" love and efforts to implement. so the easiest and recommended way should to create an automation in HA for this use case 😉

overall this ticket can be closed, as the release is done. thx @hthiery

sevorl commented 2 years ago

@mib1185 , I agree an automation would be the best way to use this. But the integration would have to expose a service that could be called from this integration, that lets you set the device id and the duration in seconds.

mib1185 commented 2 years ago

nope, just use the delay action in the automation - just an example trigger:

action:

  1. lower heating
  2. delay xx seconds/minutes
  3. recover hearing setting
sevorl commented 2 years ago

That is possible, but turns out to be quite complex in real live. The thermostate may turn on again, because of scheduled temperature changes in the Fritz app, so you would need another automation that observes if the climate mode changes while the window is open, and resets this change. But because the avm thermostates don't react instantly (may take up to 15 minutes), the heat would still go on for at least a while. Also, the display has a nice feature of showing the time when the window-open mode was set, which is convenient.

Setting window-open mode is already possible in node red, but node-red and the fritzhome integration don't work well together. It seems that Fritzbox does not like two connections from the same IP, so they are getting logged out when the other integration connects.

mib1185 commented 2 years ago

please open a feature request here https://community.home-assistant.io/c/feature-requests. It needs to be discussed if this is wanted by the users

sevorl commented 2 years ago

Yes, that is certainly the better place for this ciscussion. https://community.home-assistant.io/t/fritz-smarthome-support-window-open-mode-for-climate-devices/463716