Closed mib1185 closed 10 months ago
since #95 is merged please rebase
I agree with codeclimate result, but it complains already existing code, so i'm not sure if we should refactor this within that PR? I would suggest to put this on the todo list for a later PR?
I agree with codeclimate result, but it complains already existing code, so i'm not sure if we should refactor this within that PR? I would suggest to put this on the todo list for a later PR?
I'm fine with that.
Hi @hthiery thanks for merging all these PRs 👍 do you mind or has already planned to release a new version?
I just sent you a request on discord. Maybe we can discuss that there.
Am Mo., 15. Jan. 2024 um 10:40 Uhr schrieb Michael @.***
:
Hi @hthiery https://github.com/hthiery thanks for merging all these PRs 👍 do you mind or has already planned to release a new version?
— Reply to this email directly, view it on GitHub https://github.com/hthiery/python-fritzhome/pull/96#issuecomment-1891708063, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFGUTROQOJ4DJNB24QFALYOT2RZAVCNFSM6AAAAABB2GUA4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRG4YDQMBWGM . You are receiving this because you were mentioned.Message ID: @.***>
This will split the humidity and level related features into own classes, so they can be used by any sub device unit (eq. separate sensor units on devices). To further follow this concept, the battery related and tx_busy values are moved to the base entity. Nevertheless, the battery values from
hkr
node (thermostat) are kept for backwards compatibility with Fritz!OS < 7.08. Last but not least, there are also some debug logging added.