search

hthiery / python-fritzhome

Python Library to access AVM Fritz!Box homeautomation
MIT License
52 stars 37 forks source link

Split features and move battery and tx_busy values to base entity #96

Closed mib1185 closed 9 months ago

mib1185 commented 9 months ago

This will split the humidity and level related features into own classes, so they can be used by any sub device unit (eq. separate sensor units on devices). To further follow this concept, the battery related and tx_busy values are moved to the base entity. Nevertheless, the battery values from hkr node (thermostat) are kept for backwards compatibility with Fritz!OS < 7.08. Last but not least, there are also some debug logging added.

coveralls commented 9 months ago

Coverage Status

coverage: 94.295% (+1.1%) from 93.179% when pulling a373d8f0c8446731bfe78847bfb836aab3af6dbe on mib1185:split-devices-by-features into 8b4f0202e43e9699427ae33f2c041b0e0e07c125 on hthiery:master.

hthiery commented 9 months ago

since #95 is merged please rebase

mib1185 commented 9 months ago

I agree with codeclimate result, but it complains already existing code, so i'm not sure if we should refactor this within that PR? I would suggest to put this on the todo list for a later PR?

hthiery commented 9 months ago

I agree with codeclimate result, but it complains already existing code, so i'm not sure if we should refactor this within that PR? I would suggest to put this on the todo list for a later PR?

I'm fine with that.

mib1185 commented 9 months ago

Hi @hthiery thanks for merging all these PRs 👍 do you mind or has already planned to release a new version?

hthiery commented 9 months ago

I just sent you a request on discord. Maybe we can discuss that there.

Am Mo., 15. Jan. 2024 um 10:40 Uhr schrieb Michael @.***

:

Hi @hthiery https://github.com/hthiery thanks for merging all these PRs 👍 do you mind or has already planned to release a new version?

— Reply to this email directly, view it on GitHub https://github.com/hthiery/python-fritzhome/pull/96#issuecomment-1891708063, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFGUTROQOJ4DJNB24QFALYOT2RZAVCNFSM6AAAAABB2GUA4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRG4YDQMBWGM . You are receiving this because you were mentioned.Message ID: @.***>