Add Dockerfile and fix Blacklist - Githubissues

htilly / zenmusic

Slack / Sonos / Spotify / Node.js - Control Sonos through #Slack

125 stars 36 forks source link

Add Dockerfile and fix Blacklist #8

Closed jangrewe closed 7 years ago

jangrewe commented 7 years ago

The blacklist was read asynchronously and didn't really stop any blacklisted user from sending commands - now it does. The Dockerfile creates an Alpine based container that includes the config and blacklist at build time.

ToDo: environment variables to configure the Docker containers

coveralls commented 7 years ago

Coverage decreased (-5.9%) to 5.117% when pulling 064ff43ecbd61c96be01e63214fbedd79d07bad2 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage decreased (-5.9%) to 5.117% when pulling 064ff43ecbd61c96be01e63214fbedd79d07bad2 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage decreased (-5.9%) to 5.096% when pulling 15c85471cbded8a71196d076435a87e4f10b4cc6 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage decreased (-5.5%) to 5.508% when pulling 84b0777e1fdbc6ce5330c30cf147428dbe5cc30d on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage decreased (-5.5%) to 5.508% when pulling 84b0777e1fdbc6ce5330c30cf147428dbe5cc30d on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+1.04%) to 12.076% when pulling 7671b0d782ea0b8fff858d74d12e24073e0bbcc5 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+1.04%) to 12.076% when pulling 7671b0d782ea0b8fff858d74d12e24073e0bbcc5 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 11.966% when pulling a0ab1173096cfabd84db1db5813210795a1f70b6 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 11.966% when pulling a0ab1173096cfabd84db1db5813210795a1f70b6 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 11.562% when pulling cc05d1eced04fb1e31d4abd2d2f085a3fa7d67c1 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 11.515% when pulling dc75927babff8dcb585ae3c1b867b4d7b378260f on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 11.515% when pulling dc75927babff8dcb585ae3c1b867b4d7b378260f on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 11.446% when pulling 8e065768165919646388a3bed9d776b41e0bb968 on jangrewe:master into 2c44c004b6bab6cd072e1691191a54b154143018 on htilly:master.

htilly commented 7 years ago

Awesome!

jangrewe commented 7 years ago

Please be aware that there were a couple more changes besides the ones mentioned in the initial commit, especially how the blacklist is configured now and how configuration options can be set - this shouldn't break anything for existing users, but some people may be surprised that their blacklist.txt doesn't work anymore ;-)

htilly commented 7 years ago

Roger! Oho, if you do have some time to spend, please have a look at _gongPlay :-D

/Tilly

jangrewe commented 7 years ago

I will! We're "launching" it in our office today, so i'll probably hold off for a couple of days, but expect more PRs from me in the future ;-)