search

htm-community / NAB

The Numenta Anomaly Benchmark
GNU Affero General Public License v3.0
3 stars 3 forks source link

enable param optimization on NAB #31

Closed psteinroe closed 4 years ago

psteinroe commented 4 years ago

See #792 for details.

Fixes #16

psteinroe commented 4 years ago

We should wait with merging this until we have a clear idea on how we want to provide optimization on nab

psteinroe commented 4 years ago

@breznak what do you think?

breznak commented 4 years ago

Apart from the smaller changes, do you think this is ready, or is there some significant TODO?

psteinroe commented 4 years ago

I think with my last commit this can be merged. I added the docs as well as better error handling (PR is coming in a few minutes, just doing a final test).

The only thing that could be improved is that right now, you have to provide every parameter to the detector. We could check if the param is given, and if not use the default value. But in my opinion this is not crucial and may even decrease usability due to a lower visibility on what's going on.