htm-community / comportex

Hierarchical Temporal Memory in Clojure
154 stars 27 forks source link

Separate encoders from senses #26

Closed floybix closed 8 years ago

floybix commented 8 years ago

This implements half of #19 i.e. separating encoders from senses, not yet changing encoders at all.

To be coordinated with a corresponding change to ComportexViz, hence set version to 0.0.10-SNAPSHOT.

In particular, any thoughts on the argument signatures of region-network and regions-in-series (since these are important parts of the API) and the revised PHTM function names?

mrcslws commented 8 years ago

I like what I see. I like how it makes the API cleaner (long live sensory-input). I'll play with it once it's merged, including calling region-network directly (I'm about to experiment with multiple inputs vs encating inputs).

:+1:

mrcslws commented 8 years ago

And I like this vocabulary, untangling "sense" from "input".

floybix commented 8 years ago

Ok cool, thanks for the review.

On Tuesday, August 25, 2015, Marcus Lewis notifications@github.com wrote:

And I like this vocabulary, untangling "sense" from "input".

— Reply to this email directly or view it on GitHub https://github.com/nupic-community/comportex/pull/26#issuecomment-134503833 .

Felix Andrews / 安福立 http://www.neurofractal.org/felix/