search

htm-community / hitc

HTM In The Cloud
GNU Affero General Public License v3.0
7 stars 7 forks source link

Update test client and fixed timestamp bug #28

Closed JonnoFTW closed 8 years ago

JonnoFTW commented 8 years ago

Fixes #26.

Fixed a bug where the server only used the current timestamp, instead of the provided one. Also updated the test client to use the new API client package.

rhyolight commented 8 years ago

So the fix looks great, and the test would also be great if it weren't using hitcpy. I think your unit tests should be closer to the code under test. This whole test file would fit much better in the hitpy repo, however. And once we set up CI, it will be running as an extra test.

If you want to write unit tests, I suggest you call the HTTP handler functions directly from your tests. This makes the assumption that the web framework you chose is setup properly.

rhyolight commented 8 years ago

I'm going to merge this and divert new work to new issues.

rhyolight commented 8 years ago

See https://github.com/nupic-community/hitc/issues/29 & https://github.com/nupic-community/hitc-py/issues/2