search

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications
MIT License
56 stars 23 forks source link

Breaks your octane app - be careful #103

Open BryanCrotaz opened 3 years ago

BryanCrotaz commented 3 years ago

With ember-hammertime installed:

Template Compiler Error (TemplateCompiler) in lords-fielder-tool/application/template.hbs

Cannot read property 'start' of undefined
wmlele commented 3 years ago

Same. Application breaks from 3.25.+ onwards.

jking6884 commented 3 years ago

Same. Upgraded to 3.26 and getting the same TemplateCompile error

rreckonerr commented 3 years ago

3.24 is affected too

rreckonerr commented 2 years ago

Hi, @rwwagner90 Tagging you as the last person that committed to this repo. Do you know if this repo is still maintained? It'd be great to update dependencies (especially "ember-cli-babel" that breaks the build for ember apps 3.2x+)

RobbieTheWagner commented 2 years ago

@rreckonerr it is my understanding that hammertime has not been needed for years. It was only to remove the delay from touch events, but that has been fixed in mobile browsers for awhile. Is anyone here still experiencing the delays and actually need the package or is it a leftover dependency?

rreckonerr commented 2 years ago

@rwwagner90 Thanks for a quick reply! It seems like the 300ms delay has been removed in Chrome 32+. https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away I've removed the ember-hammertime addon already and don't see any downsides yet.