search

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications
MIT License
56 stars 23 forks source link

[Inconsistent] iOS compatibility issues with iOS 9.3 / iOS10 #14

Open gnazarkin opened 8 years ago

gnazarkin commented 8 years ago

Same issue as https://github.com/runspired/ember-hammertime/issues/6. Hammertime not working with iOS 9.3, tested with 4 devices. Works perfectly on 9.2

runspired commented 8 years ago

@gnazarkin this is because of your hammertime version.

runspired commented 8 years ago

reopening because I'm realizing you said cordova specifically.

are you using the wkWebView engine or the uiWebView engine?

gnazarkin commented 8 years ago

uiWebView

alizahid commented 7 years ago

This thing never got resolved?

runspired commented 7 years ago

@alizahid mostly I never had a chance to get a uiWebView build to test. Theoretically this should not be an issue.... in practice if someone can replicate this consistently in uiWebView on a device and is willing to pair with me it's likely something simple.

runspired commented 7 years ago

@alizahid also note, I say theoretically because I was supporting multiple apps running on the mentioned iOS versions with both uiWebView and wkWebView without issue.

alizahid commented 7 years ago

@gnazarkin and I have been able to replicate this consistently. I'd like to pair, as you suggested, to get to the bottom of this. FastClick hasn't been updated in over a year and has a bunch of really annoying bugs which make it nearly unusable.

How can I help?

runspired commented 7 years ago

@alizahid after I'm done with work today I'll ping you. Same handle for Ember Slack?

alizahid commented 7 years ago

@runspired yes.

runspired commented 7 years ago

@alizahid @gnazarkin can you check version 1.1 for me (released this evening)? Please make sure to bump your versions of hammer-time in bower.json as well, should also be 1.1

Closing as I believe this is resolved by the release of 1.1.0, will reopen if not.

alizahid commented 7 years ago

I'm on iOS 10 now. Still have the delay. @runspired @gnazarkin

runspired commented 7 years ago

@arschmitz may be the best person @alizahid

alizahid commented 7 years ago

@arschmitz Halp.

arschmitz commented 7 years ago

iv never been able to replicate this on iOS 9.3 ill check 10. can you give me any more details on what your doing what elements your seeing delay on exactly how long of a delay are you seeing? Do you see this outside of webviews?

alizahid commented 7 years ago

@arschmitz If you have some time, we can talk on Ember Slack and get to the bottom of this. I can show you my code and / or app and answer any questions. We can debug this together.

alizahid commented 7 years ago

@arschmitz @gnazarkin I switched to WKWebView and that fixes the issue. The Cordova plugin is available here; https://github.com/apache/cordova-plugin-wkwebview-engine

alizahid commented 7 years ago

But WKWebView has a ton of bugs, too. So this still needs to be resolved on UIWebView.

diogomafra commented 7 years ago

I think this issue may be fixed by this PR: https://github.com/hammerjs/hammer-time/pull/34

alizahid commented 7 years ago

@diogomafra Have you tested?

diogomafra commented 7 years ago

@alizahid I've tested it on a page launching from the home screen. I think it has the same behavior on Cordova, but I haven't tested it.

RobbieTheWagner commented 6 years ago

@diogomafra @alizahid is this resolved?

lukemelia commented 4 years ago

As far as I can tell, this is still an issue.

arschmitz commented 4 years ago

hi sorry some how missed this issue way way back but saw this update the original issue on hammer time was closed and working long ago.

If i could get some fresh reproduction steps or better yet a non working example im happy to look into it though