fix error thrown when tagName has not yet been defined on a component

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications

MIT License

56 stars 23 forks source link

fix error thrown when tagName has not yet been defined on a component #26

Closed eriktrom closed 8 years ago

eriktrom commented 8 years ago

has to do with with glimmer2 component instantiation differing from glimmer1 (even without glimmer flag enabled)
affects concatenated properties and apply mixin logic in ember metal
source of actual difference in code paths unknown ATM

fixes #19

eriktrom commented 8 years ago

ready to ⛵

closing notes - the original code with the check for tagName is likely sufficient - we may want to simplify(or figured you'd want to know that we dont need the meta-programming down there - although it looks like it may allow combining styles from more than one mixin 'mixed in' to one component - so might be cool - haven't tried though - anyway - just fyi)

runspired commented 8 years ago

I'll tag a new release tonight, if you have another moment to figure out what is making the test harness choke on travis that's also appreciated :)

eriktrom commented 8 years ago

yeah dont tag a release - it seems to be adding to many touch-action attrs - something the other brranch was not doing - let me code for a bit with it tonight - will ping u back

eriktrom commented 7 years ago

Fixed and released in 1.12