First attempt at making more configurable

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications

MIT License

56 stars 23 forks source link

First attempt at making more configurable #44

Closed RobbieTheWagner closed 6 years ago

RobbieTheWagner commented 6 years ago

The idea here is to allow two new configuration options touchActionOnAction and touchActionAttributes. I have attempted to document things both in the code, and in the README, so hopefully this makes sense. We should probably also add some tests for these things.

RobbieTheWagner commented 6 years ago

This works in my testing, so I am going to merge. If for some reason we do not want this, we can revert.

runspired commented 6 years ago

I'm concerned about automatically locating onclick= and similar attributes, it's possible this introduces new bugs. If it does, we should revert. Until then, this seems ok.

RobbieTheWagner commented 6 years ago

@runspired we were already automatically doing all that. The point of this PR was to allow configuration to stop that.

runspired commented 6 years ago

oh, then even better :D