search

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications
MIT License
56 stars 23 forks source link

check config for defaults #52

Closed sbatson5 closed 6 years ago

sbatson5 commented 6 years ago

What's in this PR?

Should address the comment on this thread: https://github.com/html-next/ember-hammertime/issues/31#issuecomment-355735187

I ran into this issue as well. The README implies that by adding the EmberHammertime hash to your config/environment you can set defaults. However, the mixin does not look at the consuming app's config and overwrite the defaults. This PR would allow the user to specify which defaults they want.

scanieso commented 6 years ago

This LGTM! 🚀

RobbieTheWagner commented 6 years ago

@sbatson5 the config stuff should work. What issues are you experiencing?

RobbieTheWagner commented 6 years ago

Ah, I guess the issue is the config values work when you don't use the mixin, but the mixin does not?

eriktrom commented 6 years ago

the config stuff should work. What issues are you experiencing?

I think he wants to configure it from environment.js from within the app. If that's not it then not sure either...

RobbieTheWagner commented 6 years ago

I think this should work. Going to merge.

RobbieTheWagner commented 6 years ago

Thanks @sbatson5!

eriktrom commented 6 years ago

ps @sbatson5 - double thanks never hurts - nice job fixing this issue - its been outstanding for a good long while, appreciate it