search

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications
MIT License
56 stars 23 forks source link

add ember-cli-changelog #58

Open eriktrom opened 6 years ago

eriktrom commented 6 years ago

It includes babel 5.x in its dependencies. Fixing this should allow using it again here and in ember-gestures

wild guess atm

RobbieTheWagner commented 6 years ago

@runspired do we want to just deprecate ember-cli-changelog? It needs a lot of work, and I don't understand the code well enough to implement the changes.

eriktrom commented 6 years ago

To be honest this was my thinking as well. I could have tried to fix changelog, but it’s very old and I was wondering what other addons are using instead.

RobbieTheWagner commented 6 years ago

Most addons use lerna-changelog these days, I think. I loved the ember-cli-release and ember-cli-changelog ease of use, but would need help from @runspired to get it working well.

eriktrom commented 6 years ago

Not gonna lie, i just made 3 releases of ember-gestures manually, b/c it broke an app i asked someone to try it on. Thus I made 3 manual tags, 3 manual releases, 3 manual commit messages, 3 of everything. I borked one thing, which isn't a big deal, there's no 0.6.0 in the commit line of master, and it's message which really only travis saw said 'Released 0.4.8' b/c that's where I tagged 0.6.0 from, during the revert. Then I published a sem ver safe 1.0.0

This story shows that we need a tool back badly, i don't care which one.

I'll do the implementation. Let me know whether to fix ember-cli-changelog or use something else :)

runspired commented 6 years ago

I’ll poke at things tomorrow 🙂