search

html-next / vertical-collection

Infinite Scroll and Occlusion at > 60FPS
https://html-next.github.io/vertical-collection/
MIT License
176 stars 76 forks source link

Restore support for Ember 2.x #331

Closed mixonic closed 3 years ago

mixonic commented 3 years ago

master of the vertical-collection repo had some Ember-pre-3.x compatibility stuff removed back in 2019. For example:

Restore one of those changes.

mixonic commented 3 years ago

As @rwwagner90 reviewed https://github.com/html-next/vertical-collection/pull/321 he noted that the test suite was not running for Ember 2.x. I replied that it seemed like the 2.x test suite was just broken, indeed master generally is in a poor state.

Despite there being some 1.13 compatibility code we found and dropped as part of https://github.com/html-next/vertical-collection/pull/321, there was also an earlier effort to drop some compatibility code from master, for example in https://github.com/html-next/vertical-collection/pull/289 (as pointed out by @rwwagner90 over DM). Based on us still finding compat code on master, I had presumed that master still should support 2.x, but I was wrong!

In this PR I've restored the Ember 2.x compatibility code and massaged the ember try config until we have a suite passing through all of 2.x.