search

html-next / vertical-collection

Infinite Scroll and Occlusion at > 60FPS
https://html-next.github.io/vertical-collection/
MIT License
176 stars 76 forks source link

v3 Proposal #341

Closed mixonic closed 2 years ago

mixonic commented 2 years ago

In alignment with https://github.com/Addepar/ember-table/pull/919 (ember-table is one of the main consumers of vertical collection), I propose a v3 major release of vertical collection.

The main breaking change is: Remove support for Ember < 2.18 and ensure compatibility with Ember 4.

Thoughts?

mixonic commented 2 years ago

The PR at https://github.com/html-next/vertical-collection/pull/343 tracks a prerelease branch. CI is set up, and I'll look to extract whatever minimal changes from https://github.com/html-next/vertical-collection/pull/335 that I can get it green.

I've also pinned the minimum Node version at 14.

mixonic commented 2 years ago

3.0.0-0 has been released, and a release-2 branch for legacy v2 support has been created.

Downstream in Ember Table I've created https://github.com/Addepar/ember-table/pull/921 as a smoke test, though it doesn't run tests against Ember 4 at this point.

Please try the pre-release if applicable, and provide feedback!

runspired commented 2 years ago

@mixonic I think we forgot to actually publish the v3

mixonic commented 2 years ago

@runspired my plan was to wait until ember-table gets a stable release well tested via integration into real apps before cutting a stable here.

bakerac4 commented 2 years ago

Can this release be cut now at this point? Or are we still waiting for results from ember-table?

mixonic commented 2 years ago

I've been trying to get the last beta of ember-table successfully landed into a large app at Addepar. We're seeing unexpected width changes in cells. At first it seemed to be from the 3.0.0-0 to 3.0.0-1 changes, however I believe that analysis might have been in error and I'm debugging.

I suspect we're in the clear on the vertical collection from, though my confidence is only 80%. I'll be able to allocate some time over the next two days to try and get the style change isolated or rationalized so we can ship.

runspired commented 2 years ago

I did end up trying to use this in an app as well and found a few problems, though not necessarily caused by vertical-collection itself, and also not necessarily due to the v3 bump since we were pinned to a commit that was from a while back. For instance, if we (yes very bad) mutate objects in an array while filtering over them, and that filtered array is provided to vertical-collection, it will now blow up when it didn't before. Personally I don't think that's VC's problem since its a dastardly bad thing to do, but if lots of folks start hitting issues like that we may want to at least understand what changed.

mixonic commented 2 years ago

3.0.0 was released in early May. The issues we had been encountering with unexpected layout changed were related to a CSS bug fixed in 2.0.1 which hadn't been adopted into that codebase.

Closing this. Onward to 4.0!