html-next / vertical-collection

Infinite Scroll and Occlusion at > 60FPS
https://html-next.github.io/vertical-collection/
MIT License
176 stars 76 forks source link

Don't send action on non-existing items #359

Closed azhiv closed 1 year ago

azhiv commented 2 years ago

This is a straightforward fix for https://github.com/html-next/vertical-collection/issues/317. We tried a more sophisticated fix https://github.com/html-next/vertical-collection/pull/324, but the error didn't vanish - it rather started to appear more seldom. So eventually we decided to perform this check on the item which utterly fixes the issue.

andreyfel commented 2 years ago

@runspired @mixonic can you guys take a look?

mixonic commented 1 year ago

Addressed by https://github.com/html-next/vertical-collection/pull/391

Thank you @azhiv!