search

html5lib / html5lib-tests

Testsuite data for html5lib, including the de-facto standard HTML parsing tests.
MIT License
188 stars 61 forks source link

Fix errors in the tokenizer and tree construction tests. #136

Closed stevecheckoway closed 3 years ago

stevecheckoway commented 3 years ago

For several years, I've maintained a bunch of branches with fixes to the errors in the html5lib-tests's tokenizer and tree construction tests. There were corresponding PRs that had been open for years (#108, #109, #110, #111, #112, #113, #114, #115, #116, #117, #118, #119).

I don't think any of the html5lib-tests maintainers is currently interested in errors. That's completely fine, of course, and totally understandable since only the tokenizer errors have actually been standardized.

But in the mean time, having the correct number of errors in the tests is useful to me as I maintain the gumbo HTML parser that's used in Nokogiri. Maintaining individual branches for the specific PRs listed above plus a branch that contains all of the individual commits is too troublesome. To that end, I closed all the PRs above and I'm opening this one which contains all of the earlier fixes plus new fixes I added in the past few days.

I plan to sporadically keep this branch (and thus this PR) up to date.

Ms2ger commented 3 years ago

If @hsivonen (or someone else) doesn't object in the next two weeks, I'd just merge this.