search

html5lib / html5lib-tests

Testsuite data for html5lib, including the de-facto standard HTML parsing tests.
MIT License
188 stars 61 forks source link

Fix template not having surrounding document #161

Closed fb55 closed 1 year ago

fb55 commented 1 year ago

158 removed the fragment mode, without updating the expected document.

Originated in https://github.com/inikulin/parse5/pull/877.

fb55 commented 1 year ago

There will also be a number of errors that come up, but that I don't check for — might be easier to revert the commit. Also this makes a good case for downstream tests.

Ms2ger commented 1 year ago

cc @annevk

annevk commented 1 year ago

@fb55 hmm, does that mean we should revert my fix or was there something wrong, but my fix was incomplete?

fb55 commented 1 year ago

Template tags are allowed within other template tags, so the previous test was valid as it was. I would lean towards reverting the commit.

annevk commented 1 year ago

https://wpt.fyi/results/html/syntax/parsing/html5lib_innerHTML_template.html is what made me think the test was bogus in some way.

fb55 commented 1 year ago

Closing in favor of #165