search

html5lib / html5lib-tests

Testsuite data for html5lib, including the de-facto standard HTML parsing tests.
MIT License
188 stars 61 forks source link

Add some tests to match changes made in new ruby model #27

Closed darobin closed 10 years ago

darobin commented 10 years ago

As per http://darobin.github.io/html-ruby/. This change is being landed in the W3C specification, apply with caution.

hoppipolla-critic-bot commented 10 years ago

Critic review: https://critic.hoppipolla.co.uk/r/458

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

darobin commented 10 years ago

Just to be entirely clear: I don't suggest taking this PR before it's actually been implemented (or clearly in the process of being implemented).

gsnedders commented 10 years ago

This is in WebKit at least, AFAICT. Time to more seriously consider landing this, @darobin?

darobin commented 10 years ago

Yes, it's in WebKit and there's a patch on the way in Gecko. I have heard interest from the others, as well (but I'm not aware of anything being available at this point). I'm certainly happy for it to land, along with the python parser changes and the web-platform-test import (which'll need regeneration)!

sideshowbarker commented 10 years ago

wchen has reviewed all the gecko patches and they're just waiting for him to commit them See https://bugzilla.mozilla.org/show_bug.cgi?id=1042885#h15 and the following two comments