search

html5lib / html5lib-tests

Testsuite data for html5lib, including the de-facto standard HTML parsing tests.
MIT License
188 stars 61 forks source link

Fix tests to match Encoding spec #40

Closed gsnedders closed 9 years ago

gsnedders commented 10 years ago

See commit messages for specific changes; note this doesn't change the names to case-sensitively match the names in the Encoding spec.

Also, Encoding makes the following test problematic:

#data
<!DOCTYPE HTML>
<script>document.write('<meta charset="ISO-8859-' + '2">')</script>
#encoding
iso-8859-2

This is now a test that should return different values between the pre-parser (scanning to infinity) and the full parser! We should probably split the tests up for such things, and only allow pre-parser ones scanning to the recommended limit.

hoppipolla-critic-bot commented 10 years ago

Critic review: https://critic.hoppipolla.co.uk/r/592

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

gsnedders commented 10 years ago

Fixes #37.