search

htmlburger / carbon-fields

WordPress Custom Fields Library ✨
https://carbonfields.net/
Other
1.39k stars 246 forks source link

Deprecated warnings using PHP 8+ #1079

Closed sirjeff closed 1 year ago

sirjeff commented 2 years ago

Version

Expected Behavior

No warnings

Actual Behavior

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetExists($id) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 128

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetGet($id) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 93

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetSet($id, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 74

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetUnset($id) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 138

Container definition

Steps to Reproduce the Problem

  1. Upgrade to PHP 8.1.2
  2. Warning appears at the top of every page
emanuellopes commented 2 years ago

Same issue here, with php 8.1

TCB13 commented 2 years ago

Same here...

sirjeff commented 2 years ago

No movement on this since March. Who do I assign this problem to?

sirjeff commented 2 years ago

@vvasilev- ??

sirjeff commented 2 years ago

@tyxla or @jorostoyanov ?

tyxla commented 2 years ago

Hey folks, thanks for the ping, but I'm no longer working on this library.

slaxxarn commented 2 years ago

Same here

aldveq commented 1 year ago

Any update on this? 👀

AshleyRedman commented 1 year ago

Same Deprecated warnings here for 8.1.

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetExists($id) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 128

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetGet($id) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 93

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetSet($id, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 74

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetUnset($id) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 138

Is this lib still actively maintained?

Ste-komodo commented 1 year ago

So is the end of the road for Carbon Fields then? Pity, because this library was/is awesome.

Is it still being maintained?

lautiamkok commented 1 year ago

Same issue with PHP 8.2.1

HTMLBurger-NG commented 1 year ago

Thanks for the notes. This has been fixed in the develop branch, we'll ship new version soon.

TCB13 commented 1 year ago

Thank you.

KennethErvinYoung commented 1 year ago

Its May 28 2023, I'm running WP with PHP 8.1.3 - DId Carbon Fields get Updated so it doesn't crash? How do I get?

rooteto commented 1 year ago

Hi, You can solve this problem as below.

https://github.com/vlucas/phpdotenv/issues/504#issue-1073543626

sirjeff commented 1 year ago

I've given up. We have paid ACF account anyway so I'll stick to the add-ons that are regularly updated. Nothing against the devs here, just I have to keep moving forward with projects :(