search

htmlburger / carbon-fields

WordPress Custom Fields Library ✨
https://carbonfields.net/
Other
1.38k stars 245 forks source link

Appearance > Widgets > Add Sidebar button is added to screen #966

Open danielmilner opened 3 years ago

danielmilner commented 3 years ago

Version

Expected Behavior

I am using Carbon Fields to add post meta to a CPT as part of a plugin. I am not doing anything with sidebars, but Carbon Fields is adding an "Add Sidebar" button to my Widgets page.

Actual Behavior

I would not expect the "Add Sidebar" button to be there since I have not specified that feature anywhere.

Container definition

N/A

Steps to Reproduce the Problem

  1. Just calling \Carbon_Fields\Carbon_Fields::boot(); without creating any containers.
danielmilner commented 3 years ago

https://github.com/htmlburger/carbon-fields/issues/488 does correct the issue, but I'm not sure that it should need correcting in the first place. Shouldn't this be something that needs to be turned on instead of being on by default?

Also, what would happen if another plugin/theme also used Carbon Fields and wanted or needed the Sidebar Manager? Would I be inhibiting it from showing up at all?