htmlburger / wpemerge-theme

An organized, ES6 and SASS powered theme taking advantage of the WP Emerge framework. 🚀
https://wpemerge.com/
GNU General Public License v2.0
286 stars 33 forks source link

Should I git ignore the cache directory? #29

Closed matepaiva closed 5 years ago

matepaiva commented 5 years ago

Version

Please add the exact versions used for each of the following:

Expected behavior

I don't see any reason to do versioning on my cache files. Am I missing something?

Actual behavior

theme/cache directory is not git ignored, so it is being commited. Is there any problem if I ignore it? Why it should not be like this by default?

Steps to reproduce (in case of a bug)

  1. yarn dev
atanas-dev commented 5 years ago

Hi @matepaiva

theme/cache is not a default theme directory which is why it is not ignored. The path is an example for view extensions like blade and twig. There will be some directory changes coming to the theme soon which will most likely add a standard cache directory. So you are correct - there is no need to version your cache directory - feel free to change the directory using the appropriate configuration option depending on the view extension you are using or just git ignore theme/cache.

matepaiva commented 5 years ago

Thanks! <3