search

htmlburger / wpemerge-theme

An organized, ES6 and SASS powered theme taking advantage of the WP Emerge framework. 🚀
https://wpemerge.com/
GNU General Public License v2.0
286 stars 33 forks source link

.htaccess is blocking carbon fields assets #37

Closed quasiperfect closed 5 years ago

quasiperfect commented 5 years ago

like the title said and also the comment from the actual file "# Disable access to any theme files outside of dist/."

atanas-dev commented 5 years ago

Hi @quasiperfect ,

Ultimately the .htaccess addition was a mistake on my part as it is overzealous and it's not the job of a theme to dictate how your webserver should behave which is why .htaccess will be removed in the next version.

I'd suggest you either remove it from your theme or add vendor/htmlburger/carbon-fields/ or just vendor/ to the pipe-separated list in the file like this:

# Disable access to any theme files outside of dist/.
<IfModule mod_rewrite.c>
RewriteEngine On
RewriteRule !^(dist/|theme/screenshot.png|theme/style.css|vendor/htmlburger/carbon-fields/) - [L,R=404]
</IfModule>
quasiperfect commented 5 years ago

thanks @atanas-angelov-dev for your work