feat: Add support for svg sprite

htmlburger / wpemerge-theme

An organized, ES6 and SASS powered theme taking advantage of the WP Emerge framework. 🚀

https://wpemerge.com/

GNU General Public License v2.0

286 stars 33 forks source link

feat: Add support for svg sprite #46

Closed paulomfr closed 4 years ago

paulomfr commented 4 years ago

Discussion

Issue: #11

What this PR does

Add support for sprites svg, when add a svg file in /sprite-svg folder, webpack will bundle in one file sprite-svg.svg and the PHP will include the svg content after body tag opened.

paulomfr commented 4 years ago

@atanas-dev can you take a look at my PR?

paulomfr commented 4 years ago

@atanas-dev all changes done. I tried to use the master version to initialize a project but I'm having errors from compose. Is it unstable yet?

atanas-dev commented 4 years ago

Initializing dev-master via composer create-project won't work due to dev-master being required for all wpemerge/* packages as well. As long as you use the updated CONTRIBUTING.md steps you should be fine (via git clone rather than composer create-project).

I'll do my best to review the PR in the next few days.

atanas-dev commented 4 years ago

Thank you for the contribution, @paulomfr ! There are a couple details left but I'll take care of them in master ;)