htmlburger / wpemerge

A modern, MVC-powered WordPress as a CMS workflow. 🚀
https://wpemerge.com/
GNU General Public License v2.0
453 stars 38 forks source link

Constants and key problems. #32

Closed ghost closed 3 years ago

ghost commented 3 years ago

I think this framework has some big problems and I think Anatas needs to take a real serious look at it. Specifically, I downloaded both the theme and the plugin, typed composer install inside the folders and downloaded the packages.

Unfortunately in both cases I get the error of the missing constant WPEMERGE_APPLICATION_FILESYSTEM_KEY.

I found this constant in the config.php file on github of the 0.16.0 version of the framework (note that composer installs version 0.16.0 but that constant is not defined .... mahhh) and I made a copy and paste of the if all condition inside the config.php file

Please note that in the same version of the framework the constant is missing from version downloaded via composer and exists in the online version with a same verison number ... this is a mystery.

Cattura

Obviously after putting it doesn't work and the new error is: 'Fatal error: Uncaught Pimple\Exception\UnknownIdentifierException: Identifier wpemerge.application.filesystem is not defined.

Cattura

Last note:

This framework will ever have any chance of working or is it just a way to give developers a nervous breakdown.

Last gift:

The commands suggested on your site for quickstart

composer create-project htmlburger/wpemerge-theme wpemerge

no longer work and npm hangs for over an hour on libraries that are no longer supported.

atanas-dev commented 3 years ago

Specifically, I downloaded both the theme and the plugin, typed composer install inside the folders and downloaded the packages.

This is not the official way to get the latest published release of either project. The Quickstart sections in the documentation refer to the official way. Cloning the GitHub repos will clone the master branch of only the root project you're looking at but none of the master branches of the dependencies hence the failures. The master branches are not production-ready and users should stick to the tagged releases instead and what the official documentation suggests (i.e. via composer create-project).

The commands suggested on your site for quickstart composer create-project htmlburger/wpemerge-theme wpemerge no longer work and npm hangs for over an hour on libraries that are no longer supported.

I just ran the exact command you pasted in a clean directory and the project was created, Composer and NPM dependencies installed and the assets were built without problem. Unless I get more information about specific failures I cannot suggest a specific solution. My baseline suggestion would be to make sure you're using the latest Node and NPM (Yarn is usually more performant and supported) before trying again.

I understand things can be frustrating sometimes but this is free software provided to you by my free labor and I believe this warrants that we maintain some level-headedness when discussing frustrations.

ghost commented 3 years ago

This is not the official way to get the latest published release of either project. The Quickstart sections in the documentation refer to the official way. Cloning the GitHub repos will clone the master branch of only the root project you're looking at but none of the master branches of the dependencies hence the failures. The master branches are not production-ready and users should stick to the tagged releases instead and what the official documentation suggests (i.e. via composer create-project).

A moment please because I can't understand this.

You release one version of the theme and one version of the plugin based on the same version of the framework. Otherwise I have to believe that there are two versions 0.16.0 and this, checking your github, does not seem possible to me because the version is only one.

I don't understand why the same version of the framework has so many and such differences. We are talking about pieces of code that exist in one version not the other, but both have the same version number.

At this point tell me if the system requirements are right: PHP Version: 7.4.15/8.0.1 Composer Version: 2.1.9 NPM Version: 6.4.18

I repeat that I tried the commands you illustrated on the site and after an hour and thirty-five minutes I closed the PowerShell window because everything was blocked; including computer.

Here it stops and does not go further. The only way is to close PowerShell.

Cattura

Update: I tried a third time and this is the result

Cattura

atanas-dev commented 3 years ago

For whatever reason, NPM times out. The project does not include an untypical number of NPM dependencies so this is either an issue of PowerShell, Node, NPM or a combination of them.

I'd suggest you give Yarn a try as it is usually more performant:

  1. Run npm i -g yarn to install yarn.
  2. Delete the node_modules directory if it exists.
  3. Run yarn install to install the dependencies.
  4. Run yarn build to build the theme assets.
ghost commented 3 years ago

Anatas ... the project doesn't include as many dependencies as you say, but that's what happens with the composer install command.

Okay ... forget it.