htmlhint / HTMLHint

⚙️ The static code analysis tool you need for your HTML
https://htmlhint.com
MIT License
3.09k stars 382 forks source link

Update Node versions used on GitHub Actions #1283

Closed coliff closed 1 year ago

coliff commented 1 year ago

Use v14, v16 and v18. REF: https://github.com/nodejs/release#release-schedule

codecov[bot] commented 1 year ago

Codecov Report

Merging #1283 (5d0295e) into master (02edc57) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5d0295e differs from pull request most recent head 1487458. Consider uploading reports for the commit 1487458 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/htmlhint/HTMLHint/pull/1283/graphs/tree.svg?width=650&height=150&src=pr&token=S8oI6yuz12&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint)](https://codecov.io/gh/htmlhint/HTMLHint/pull/1283?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint) ```diff @@ Coverage Diff @@ ## master #1283 +/- ## ======================================= Coverage 99.07% 99.07% ======================================= Files 2 2 Lines 1627 1627 Branches 332 332 ======================================= Hits 1612 1612 Misses 15 15 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/htmlhint/HTMLHint/pull/1283?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/htmlhint/HTMLHint/pull/1283?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint). Last update [02edc57...1487458](https://codecov.io/gh/htmlhint/HTMLHint/pull/1283?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint).
coliff commented 1 year ago

is this good to merge @nschonni @thedaviddias ?

nschonni commented 1 year ago

Same comment as https://github.com/htmlhint/HTMLHint/issues/1202#issuecomment-1283484433 I think it makes sense, but dropping supported versions is usually a semver major change, so it needs a version bump. It would probably be the time to include the other breaking change in https://github.com/htmlhint/HTMLHint/pull/728

coliff commented 1 year ago

Same comment as #1202 (comment) I think it makes sense, but dropping supported versions is usually a semver major change, so it needs a version bump. It would probably be the time to include the other breaking change in #728

Ok - thanks for feedback and suggestion. Updated now and all tests are passing! 👍