htmlhint / HTMLHint

⚙️ The static code analysis tool you need for your HTML
https://htmlhint.com
MIT License
3.07k stars 375 forks source link

refactor!: Bump minimum supported Node.js version to v16 #1369

Closed hyperupcall closed 5 days ago

hyperupcall commented 9 months ago

Short description of what this resolves:

Node.js v16 just hit EOL a few months ago. I saw that Node.js v16 was still in CI, which is even older, so I didn't make v18 the minimum since it seems this repository lags behind.

Let me know if I should make v18 the minimum - that's one less upgrade in the future and less worry about using dependencies that could set their minimums to v18.

Proposed changes:

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 72.46377% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 97.94%. Comparing base (22c5716) to head (5442446). Report is 9 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369/graphs/tree.svg?width=650&height=150&src=pr&token=S8oI6yuz12&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint)](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint) ```diff @@ Coverage Diff @@ ## master #1369 +/- ## ========================================== - Coverage 99.07% 97.94% -1.13% ========================================== Files 2 2 Lines 1627 1658 +31 Branches 332 341 +9 ========================================== + Hits 1612 1624 +12 - Misses 15 34 +19 ``` | [Files](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint) | Coverage Δ | | |---|---|---| | [src/cli/parse-glob.ts](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint#diff-c3JjL2NsaS9wYXJzZS1nbG9iLnRz) | `100.00% <100.00%> (ø)` | | | [dist/htmlhint.js](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint#diff-ZGlzdC9odG1saGludC5qcw==) | `97.94% <72.05%> (-1.13%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint). Last update [21022c6...5442446](https://app.codecov.io/gh/htmlhint/HTMLHint/pull/1369?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=htmlhint).
hyperupcall commented 8 months ago

I know this is a big PR, and I haven't contributed to repository before, so I'm not sure if it would be preferred merging this #1369 first, or my smaller MRs like #1370 and #1368

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.