Closed hyperupcall closed 5 days ago
Attention: Patch coverage is 72.46377%
with 19 lines
in your changes are missing coverage. Please review.
Project coverage is 97.94%. Comparing base (
22c5716
) to head (5442446
). Report is 9 commits behind head on master.
I know this is a big PR, and I haven't contributed to repository before, so I'm not sure if it would be preferred merging this #1369 first, or my smaller MRs like #1370 and #1368
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Short description of what this resolves:
Node.js v16 just hit EOL a few months ago. I saw that Node.js v16 was still in CI, which is even older, so I didn't make v18 the minimum since it seems this repository lags behind.
Let me know if I should make v18 the minimum - that's one less upgrade in the future and less worry about using dependencies that could set their minimums to v18.
Proposed changes:
"engines"
configuration (v16 is already used in.nvmrc
)tsconfig.json
to use v16 presetmodule
/moduleResolution
), some updates to the imports had to be madetsconfig.json
options of recent TypeScript version