search

htmlhint / HTMLHint

⚙️ The static code analysis tool you need for your HTML
https://htmlhint.com
MIT License
3.09k stars 382 forks source link

Exception after upgrading to htmlhint 0.12.0 #372

Closed doberkofler closed 4 years ago

doberkofler commented 4 years ago

Describe the bug

Javascript exception whentrying to run htmlhint 0.12.0:

/Users/doberkofler/MyDev/ljs_app/trunk/periscope/node_modules/htmlhint/dist/htmlhint.js:95
          return f;
          ^^^^^^

SyntaxError: Unexpected token 'return'

Desktop (please complete the following information):

hubby2004 commented 4 years ago

Same issue on a different OS:

Desktop (please complete the following information):

OS: Windows 10.0.14393 Visual Code 1.37.0 Node.js: 10.11.0

mobilemind commented 4 years ago

same issue on CLI with htmlhint -V

htmlhint@0.12.0 macOS: 10.15.4 node: v14.2.0 npm: 6.14.5

thijstriemstra commented 4 years ago

Unable to upgrade to 0.12.0 with this error. htmlhint is completely broken right now, can we have a new release?

thedaviddias commented 4 years ago

@thijstriemstra A PR #381 has been open if you want to take a look. It should fix the issue. 🙂

simon-rade-n8 commented 4 years ago

I think 0.12.1 doesn't work either. I think htmlhint.js file is expected, htmlhint.min.js present.

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module '../dist/htmlhint.js'
thedaviddias commented 4 years ago

@simon-rade-n8 my bad, I'm gonna fix this, need to update the rollup config.

thedaviddias commented 4 years ago

@simon-rade-n8 @doberkofler can you confirm that the issue is gone with the last release? 🙏

doberkofler commented 4 years ago

Yes, the problem is gone. Thank you!