htmlhint / SublimeLinter-contrib-htmlhint

A SublimeLinter plugin for HTML, using HTMLHint.
MIT License
34 stars 5 forks source link

Use selector to detect syntax #11

Closed borela closed 6 years ago

borela commented 6 years ago

Fixes: Compatibility with external HTML syntaxes that has a different name but the same root scope. Example: https://github.com/borela/naomi/issues/173

🚨 Please review the guidelines for contributing and our code of conduct to this repository. 🚨 Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:

Short description of what this resolves:

Detect any HTML syntax by scope instead of name, this will enable the plugin to work with HTML4, HTML5, etc... syntaxes.

Proposed changes:

Add the selector and remove syntax name.

👍 Thank you!

borela commented 6 years ago

I had to disable D211 because it was conflicting with D203, it seams to be the change that required the least amount of comestic changes to the current code style.

thedaviddias commented 6 years ago

Ok. I think it's good for now.

mmaday commented 6 years ago

👍