htmlpreview / htmlpreview.github.com

HTML Preview for GitHub Repositories
htmlpreview.github.com
1.53k stars 307 forks source link

Pull Request: Style Improvements #63

Open hifocus opened 5 years ago

hifocus commented 5 years ago

Hi. Thanks for developing htmlpreview/htmlpreview.github.com as a widely used tool on GitHub.

Today I tried to improve the style of this repo and found it good enough and worth for a pull request. My skills are poor so please do not mind if you don't like it.

Changes

Deprecated

Preview

I hope you are still having eyes on this old old project and consider to merge my pull request.

niutech commented 5 years ago

Thanks for your work, but please keep in mind that index.html and its assets are being loaded on each invocation of https://htmlpreview.github.io/?https://...., so it should be as small as possible with no external assets (such as Spectre). Could you please make it more lightweight, include only used CSS, etc? Thanks!

hifocus commented 5 years ago

Hi. Thanks for the suggestion. Spectre.css is a super lightweight CSS Framework. And I load it though jsDelivr, which is a global-optimised CDN.

image

Please see screenshot below, under a normal home bandwidth environment, the spectre.css can be loaded within less than 1 seconds. So I would believe that it would not have obvious effect with the general loading speed.

Please re-consider my pull request. Thanks!

scarrrr316 commented 2 years ago

YQL api service has shut down