htmlstreamofficial / preline

Preline UI is an open-source set of prebuilt UI components based on the utility-first Tailwind CSS framework.
https://preline.co
Other
4.9k stars 309 forks source link

Fix: Stepper reset handler #381

Closed PruthviPraj00 closed 1 month ago

PruthviPraj00 commented 5 months ago

Hello @olegpix,

Problem

I encounter an issue with the stepper component. When the reset button is clicked, other elements like navigation and buttons reset correctly, but the content of the final step is still displayed, as shown in the image below.

Preline Documentation image Screenshot 2024-06-02 183039

It appears that the issue is caused by the placement of the following code:

//  handleResetButtonClick()
this.setCurrentNavItem();
this.setCurrentContentItem();
this.showFinishButton();
this.showCompleteStepButton();
this.checkForTheFirstStep();

// This code
this.unsetCompleted();
this.isCompleted = false;

Solution

The problem is resolved by placing the following code above the other function calls:

this.unsetCompleted();
this.isCompleted = false;

this.setCurrentNavItem();
this.setCurrentContentItem();
this.showFinishButton();
this.showCompleteStepButton();
this.checkForTheFirstStep();

Moving this.unsetCompleted(); and this.isCompleted = false; above the other function calls ensures that the content resets properly along with the navigation and buttons.

Solved image

https://github.com/htmlstreamofficial/preline/assets/110020770/454d7317-aa00-4109-9def-c45981899e5b

VictorVSa commented 3 months ago

This seems to be easy to review, could this get merged soon?