Open mohsinhijazee opened 1 month ago
@olegpix Thank you for your feedback!
I have removed everything that was not relevant (package.json
scripts, generated dist/
and other d.ts
files including the change related to select
plugin) so I hope it is easier to review now.
Also, about packaging and bundling, I think some scripts or steps should be documented within the package.json
etc. Not so sure about it. What steps/process do you guys follow for that?
@olegpix Thank you for your feedback!
I have removed everything that was not relevant (
package.json
scripts, generateddist/
and otherd.ts
files including the change related toselect
plugin) so I hope it is easier to review now.Also, about packaging and bundling, I think some scripts or steps should be documented within the
package.json
etc. Not so sure about it. What steps/process do you guys follow for that?
Hi, The process is quite simple, you need to run 3 tasks from the Preline root (consistently):
We'll check and approve your PR after the next update, now we are focused on some other tasks. Thank you for your work!
This PR proposes few additions to the ComboBox.
I have tested this with SvelteKit and wrapped the Combox as a Svelte Component with full events and multiple instances of the component on the same page fetching data from difference sources so many copies/instances work seemlessly.
Few fixes/improvements:
window.$hsComboBoxCollection
being initialised. Thus users for bundlers (vite etc) don't have to load all ofpreline.js
.Additions to the CombBox:
apiSearchQueryTransformer
to allow transforming query beforefetch
. This is required in case some APIs use more advanced filtering DSL such as Google's AIP-160 for examplefilter=prefix('name', 'sh') OR contains('lastName', 'sh')
etc.selectedItem()
returns elemnent that was selectedselectedValue()
returns the value.selectedAttr(attr)
returns the custom attribute.Few other changes to the package.json (required dependencies added, deprecated type definitions replaced with updated packages), few scripts/watch/commands and generation scripts added.
Don't have full context on design choices so some things might seem absurd and I am here to revise as per your feedback FYI @jahaganiev and @olegpix