search

htmlwidgets / sparkline

jQuery Sparkline HTML Widget for R
Other
244 stars 40 forks source link

Updated NAMESPACE to include renderSparkline and sparklineOutput. #16

Closed datawookie closed 7 years ago

datawookie commented 8 years ago

Hi!

I was extremely excited to find that a package existed for generating Sparklines. I am planning on using them in a Shiny app, but found that although the renderSparkline and sparklineOutput functions have been implemented, they are not yet exported.

In this commit I have added them to the NAMESPACE file. Please consider adding this change to the master repository.

Also I'd be extremely pleased to contribute further on this package. I have noted that there is currently no documentation. I'd be happy to make a start by documenting the exposed functions.

Best regards, Andrew.

timelyportfolio commented 8 years ago

@DataWookie , see #15 where I have started to address issues mentioned. Happy to work with you on this. You can test with:

devtools::install_github("timelyportfolio/sparkline@update/sparkline")
datawookie commented 8 years ago

Great. Good to see that you have started with the documentation. I'll jump in on that shortly.

timelyportfolio commented 7 years ago

I think we can close this since I think this is addressed in #15 which I am about to merge