search

htmlwidgets / sparkline

jQuery Sparkline HTML Widget for R
Other
244 stars 40 forks source link

Add package to CRAN #17

Open fbreitwieser opened 7 years ago

fbreitwieser commented 7 years ago

Sparklines are really useful in connection with DT. Are there plans to put the package to CRAN?

timelyportfolio commented 7 years ago

I'll plan to accept #15, and then prep for CRAN. @ramnathv, are you ok with this?

timelyportfolio commented 7 years ago

@fbreitwieser, do you mind testing the changes in #15 by 

devtools::install_github("timelyportfolio/sparkline@update/sparkline")

? Thanks!

fbreitwieser commented 7 years ago

Sure, will do!

fbreitwieser commented 7 years ago

Hi @timelyportfolio , I tested your changes in some of my applications and the supplied examples with Chromium, Chrome and Firefox on Linux. All I tested so far works well and renders as expected. I'll come back to this issue when I have more observations.

timelyportfolio commented 7 years ago

fantastic @fbreitwieser, thanks for the help. Will run CRAN checks and try to better document and add some examples and vignettes

timelyportfolio commented 7 years ago

should have referenced this issue in the following commits arranged in ascending order

7b62ac75483e3443139119392cf5f9f5332c2cb8 60eaf578ea2d107cc6c11aef2dc3b76b257bbe88 47d7cd4f9b21628d12bece8d8442da670291a894 0ef2aedce1cdde9f2c476404ca51c926e944d371 4d7329da834a19b89a27bc34e4092bfdfb9dc880 b9fd58493208469334a9ebf19af4ab00679bdc58 e2e615049cc1ef8a89b59e3a71b61b8a3579b479

timelyportfolio commented 7 years ago

@ramnathv, will you please review if you have a little bit of time? If no time, let me know, and I will just hit submit :)

timelyportfolio commented 7 years ago

All prepped and ready. Now waiting for new CRAN version of htmlwidgets https://github.com/ramnathv/htmlwidgets/commit/b759e052ce3383946370f63e3ff41ce9d873b1cc

timelyportfolio commented 7 years ago

just submitted to CRAN