Allow spk_add_deps work on shiny.tag.list and html & Export html_dependency_sparkline

htmlwidgets / sparkline

jQuery Sparkline HTML Widget for R

Other

244 stars 40 forks source link

Allow spk_add_deps work on shiny.tag.list and html & Export html_dependency_sparkline #29

Closed haozhu233 closed 5 years ago

haozhu233 commented 5 years ago

shiny.tag.list & html work in a very similar way with shiny.tag. Right now skp_add_deps can only work with htmlwidgets and shiny.tag. I guess it won't hurt anyone if we expend the support to shiny.tag.list and html.

Also, rmarkdown has a pretty nice way to export its dependencies, such as html_dependency_bootstrap. So I exported spk_dependencies as html_dependency_sparkline.

timelyportfolio commented 5 years ago

Thanks @haozhu233. I like these changes. @ramnathv do you have any comments?

ramnathv commented 5 years ago

@haozhu233 Your argument for extending makes sense. I will go ahead and merge your PR. Thanks!