Open blub4747 opened 3 years ago
Armbian uses old htop version 2.2.0 with custom patches.
These patches are published here: https://github.com/armbian/build/tree/master/packages/extras-buildpkgs/htop/debian/patches
CPU/GPU temperature, frequency, Vcore are very useful. Disk/MMC/Ethernet stats are useful, too.
Bigger part of armbian patches should be integrated with mainstream htop IMHO.
Scrolling through the patches the major one with stuff that looks interesting is https://github.com/armbian/build/blob/master/packages/extras-buildpkgs/htop/debian/patches/avafinger-cpu-monitor.patch
Unfortunately there are several issues (list incomplete):
CRT.c
's CRT_init
shouldn't be in production patcheseth2
, ens5p2
or lxcbr2
…strcpy
in Settings.c
are evil (classic heap buffer overflow)Interfaces.c
is missing a copyright headerstrcpy
in ReadKeyValue
and ReadTokenValue
can also be exploited for buffer overruns trivially (missing length checks)In recent releases of htop we increased the possibilities of the Meters interface quite a bit and thus for a network or blockdevice meter for a particular device that device should use the proper interfaces provided in those recent versions. Please compare with our dev branch.
Due to the quality (or better lack thereof) of the downstream patch, I recently notified the Armbian maintainers about several security issues in their downstream patch series. And while the proposed patch looks like it may address the most obvious problems, there's still quite a list of things to work on.
That being said, we'll not be taking these downstream patches to implement those features: That just wont meet our quality standards at all.
FWIW: Cross-referencing here, for the Armbian guys to have a cross-reference with the other issues.
hello community,
I am trying to tell htop show additional information like the uptime and interface information such as. IP address and interface stats. Like seen in other examples such as armbian. I did try to replicate their example on my xubuntu without any luck.
maybe someone can please tell me where I am going wrong Thx, to everyone blub4747