search

htrc / htrc-feature-reader

Tools for working with HTRC Feature Extraction files
37 stars 12 forks source link

Remove ujson dependency from setup.py? #31

Closed bmschmidt closed 4 years ago

bmschmidt commented 4 years ago

Trying to install on a wonky machine, I found I had to manually remove the entry for ujson from setup.py because I was having trouble compiling it.

In general, ujson is a dead package; it might be worth switching to orjson for speed. But since there's already a fallback to standard json in the code here, I don't think it would hurt to just remove it from the setup?

organisciak commented 4 years ago

I'll update this in the Massive Texts fork, since I'll be looking to merge that here in the coming month or so. orjson looks good - the built-in library was a bottleneck. The side benefit is that I can stop maintaining a conda package for ujson!

organisciak commented 4 years ago

... but looks like I'll have to build an orjson conda package.

organisciak commented 4 years ago

Updated https://github.com/massivetexts/htrc-feature-reader/commit/7eae68aa368f3e1bc41b36a4f504f8bbe6ff46c8 with rapidjson, which seems better supported.