search

htrc / htrc-feature-reader

Tools for working with HTRC Feature Extraction files
37 stars 12 forks source link

syntax error in htrc_features/feature_downloader.py #4

Closed keithfma closed 8 years ago

keithfma commented 8 years ago

I was trying to build a conda recipie for this package, and encountered a syntax error in htrc_features/feature_downloader.py. The logging.error() call is missing the closing parenthesis. After patching this file, I was able to build successfully.

Best, Keith Ma

organisciak commented 8 years ago

Oh goodness, I couldn't figure this out, there never was a feature_downloader.py in the repo. I had a placeholder file on my system (which doesn't do anything yet!), and I suppose I inadvertently built it into the distribution. I'll correct that.

organisciak commented 8 years ago

I believe I removed that junk file in distribution 1.42, but I'll need to reinstall my testing environment on my new computer to try a clean install. I'll confirm this evening.

keithfma commented 8 years ago

Thanks, much appreciated.

organisciak commented 8 years ago

Seems to be fixed.