htrc / torchlite-frontend

Torchlite web interface
https://torchlite-htrc.vercel.app
1 stars 0 forks source link

Ramdevelop #95

Closed sriram04 closed 6 months ago

sriram04 commented 6 months ago

SimpleTagCloud Widget (is being included)

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchlite ❌ Failed (Inspect) May 9, 2024 4:28am
sandeep-ps commented 6 months ago

Hi, @sriram04, Is this PR ready for review? I just had my local development environment setup and thought I can review this PR, if it's ready. Please let me know. Thanks.

CC: @dkudeki

dkudeki commented 6 months ago

@sandeep-ps Yes, please take a look at this PR alongside the corresponding PR in the torchlite-backend repo and make sure you can get them working locally. I would also like to review the code to make sure none of the changes made to get the code working on @sriram04's machine have persisted, so if you take a look at it before I have a chance to, please don't merge the PR, and likewise, I'll just review without merging if I end up checking it out before you.

sriram04 commented 6 months ago

Hello Sandeep, hope you are doing well. Yes, my code is ready for review. Feel free to check it and if there is anything you can reach out to me.

Thankyou


From: Sandeep Puthanveetil Satheesan @.> Sent: Wednesday, May 1, 2024 2:41 AM To: htrc/torchlite-frontend @.> Cc: Sriram Reddy @.>; Mention @.> Subject: Re: [htrc/torchlite-frontend] Ramdevelop (PR #95)

Hi, @sriram04https://github.com/sriram04, Is this PR ready for review? I just had my local development environment setup and thought I can review this PR, if it's ready. Please let me know. Thanks.

CC: @dkudekihttps://github.com/dkudeki

— Reply to this email directly, view it on GitHubhttps://github.com/htrc/torchlite-frontend/pull/95#issuecomment-2087335789, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALQKNO53NEX6BZBDCRNSCP3ZAACI5AVCNFSM6AAAAABGXXNAHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXGMZTKNZYHE. You are receiving this because you were mentioned.Message ID: @.***>

sandeep-ps commented 6 months ago

Thanks. I will review this today. I have updated reviewers list.