search

htrc / torchlite-frontend

Torchlite web interface
https://torchlite-htrc.vercel.app
1 stars 0 forks source link

Added code changes to display Summary widget in Home screen #97

Closed poojts closed 6 months ago

poojts commented 6 months ago
  1. Modified Index page of home.
  2. Added new folder containing summary widget code
vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchlite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 5:23pm
sandeep-ps commented 6 months ago

Hi, @poojts, Do I need to do something specific to view the Summary dashboard on the home page? I switched my local frontend instance to this branch, but I'm seeing only Mapping Contributor Data and Publication Date Timeline. Please let me know. Thanks.

poojts commented 6 months ago

Hi Sandeep,

There is no changes needed to view the widget. I will check the issue and let you know.

Thanks, and Regards, Pooja

On Thu, 9 May, 2024, 3:48 pm Sandeep Puthanveetil Satheesan, < @.***> wrote:

Hi, @poojts https://github.com/poojts, Do I need to do something specific to view the Summary dashboard on the home page? I switched my local frontend instance to this branch, I'm seeing only Mapping Contributor Data and Publication Date Timeline. Please let me know. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/htrc/torchlite-frontend/pull/97#issuecomment-2103311703, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ANDDGICB65VR3N3HETYO3ZBPHJTAVCNFSM6AAAAABHC6K7P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGMYTCNZQGM . You are receiving this because you were mentioned.Message ID: @.***>

sandeep-ps commented 6 months ago

When reviewing this PR, I was using the backend branch related to word cloud, if that helps. I will try with the develop branch later.

Sent from my mobile

Best regards, Sandeep

On May 9, 2024, at 4:20 PM, Pooja Shashidhar @.***> wrote:



Hi Sandeep,

There is no changes needed to view the widget. I will check the issue and let you know.

Thanks, and Regards, Pooja

On Thu, 9 May, 2024, 3:48 pm Sandeep Puthanveetil Satheesan, < @.***> wrote:

Hi, @poojts https://github.com/poojtshttps://urldefense.com/v3/__https://github.com/poojts*3E__;JQ!!DZ3fjg!7cttpwttoM66qRo5he6mn3D7XWCP-QxrDPwspk9Oc4zkg8t1X7byuhZSQeglJXBHCSUab68JfRgZsqEHc-79uhpEHXs$, Do I need to do something specific to view the Summary dashboard on the home page? I switched my local frontend instance to this branch, I'm seeing only Mapping Contributor Data and Publication Date Timeline. Please let me know. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/htrc/torchlite-frontend/pull/97#issuecomment-2103311703https://urldefense.com/v3/__https://github.com/htrc/torchlite-frontend/pull/97*issuecomment-2103311703*3E__;IyU!!DZ3fjg!7cttpwttoM66qRo5he6mn3D7XWCP-QxrDPwspk9Oc4zkg8t1X7byuhZSQeglJXBHCSUab68JfRgZsqEHc-79u_NCm_A$, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ANDDGICB65VR3N3HETYO3ZBPHJTAVCNFSM6AAAAABHC6K7P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGMYTCNZQGMhttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A3ANDDGICB65VR3N3HETYO3ZBPHJTAVCNFSM6AAAAABHC6K7P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGMYTCNZQGM*3E__;JQ!!DZ3fjg!7cttpwttoM66qRo5he6mn3D7XWCP-QxrDPwspk9Oc4zkg8t1X7byuhZSQeglJXBHCSUab68JfRgZsqEHc-79R7aqOmE$ . You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/htrc/torchlite-frontend/pull/97*issuecomment-2103437650__;Iw!!DZ3fjg!7cttpwttoM66qRo5he6mn3D7XWCP-QxrDPwspk9Oc4zkg8t1X7byuhZSQeglJXBHCSUab68JfRgZsqEHc-79Z2zmvmM$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABA3NLHRD4LHZVJMZVABBSDZBPSCLAVCNFSM6AAAAABHC6K7P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGQZTONRVGA__;!!DZ3fjg!7cttpwttoM66qRo5he6mn3D7XWCP-QxrDPwspk9Oc4zkg8t1X7byuhZSQeglJXBHCSUab68JfRgZsqEHc-79eX53jrk$. You are receiving this because your review was requested.Message ID: @.***>

sandeep-ps commented 6 months ago

I see that other widgets have corresponding models in https://github.com/htrc/torchlite-backend/tree/develop/htrc/torchlite/widgets. Does Summary widget needs to have something similar? Or if it needs to be add to a dashboard, please let me know how it's done. Thanks.

poojts commented 6 months ago

Hai Sandeep ,

I am able to see the widget in my local branch. I have not added any model in the widget folder. Can you please change your branch to my development branch and check once.

Thanks & Regards, Pooja

On Fri, 10 May, 2024, 2:42 pm Sandeep Puthanveetil Satheesan, < @.***> wrote:

I see that other widgets have corresponding models in https://github.com/htrc/torchlite-backend/tree/develop/htrc/torchlite/widgets. Does Summary widget needs to have something similar? Or if it needs to be add to a dashboard, please let me know how it's done. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/htrc/torchlite-frontend/pull/97#issuecomment-2105098101, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ANDDGVX5RWNOFC2M6F36TZBUII7AVCNFSM6AAAAABHC6K7P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGA4TQMJQGE . You are receiving this because you were mentioned.Message ID: @.***>

poojts commented 6 months ago

On Mon, 13 May, 2024, 12:51 pm Pooja Shashidhar, < @.***> wrote:

Hai Sandeep ,

I am able to see the widget in my local branch. I have not added any model in the widget folder. Can you please change your branch to my development branch and check once.

Thanks & Regards, Pooja

On Fri, 10 May, 2024, 2:42 pm Sandeep Puthanveetil Satheesan, < @.***> wrote:

I see that other widgets have corresponding models in https://github.com/htrc/torchlite-backend/tree/develop/htrc/torchlite/widgets. Does Summary widget needs to have something similar? Or if it needs to be add to a dashboard, please let me know how it's done. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/htrc/torchlite-frontend/pull/97#issuecomment-2105098101, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ANDDGVX5RWNOFC2M6F36TZBUII7AVCNFSM6AAAAABHC6K7P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGA4TQMJQGE . You are receiving this because you were mentioned.Message ID: @.***>

dkudeki commented 6 months ago

@poojts Widgets need a component in both the frontend and backend repos. The retrieval and processing of data from the EF-API should be happening on the backend, especially when the widget handles features data. I've taken the fetchDataFromAPI() function here which handles that logic, and reimplemented it in the python backend here: https://github.com/htrc/torchlite-backend/blob/summary/htrc/torchlite/widgets/summary.py in a branch built to associate with these frontend changes.

It looks to me like you probably started building this before David did some major refactors, so I've made some updates to integrate those changes. It looks close to being ready. I had to add some stuff for the detailed view including converting the data in to a table/CSV that you might have opinions on. The main issue I see right now is that I'm having trouble generating a PNG version of the widget to download