search

htrefil / rkvm

Virtual KVM switch for Linux machines
MIT License
386 stars 50 forks source link

Consider moving config examples in `/usr/share` and make them readable by non-root users, and suggest putting config files in $XDG_CONFIG_HOME #37

Closed JPenuchot closed 1 year ago

JPenuchot commented 1 year ago

Hello,

I see that the instructions suggest to put configuration files and certificates in /etc/ which is very confusing, and seems unnecessary? Especially the fact that the configuration file is not readable for non-root users.

I was wondering if there is a rationale behind this choice when Synergy/Input-Leap do just fine with configuration files in user directories. Maybe because you have a password in the configuration file but then why having a password when you could manage access using keys and certificates instead?

It's not like it's a deal breaker at all but config examples are conventionally located in directories like /usr/share/rkvm/examples or /usr/share/doc/rkvm/examples and readable by non-root users.

Anyway, thanks for the effort, really appreciate your work :)

Regards, Jules

htrefil commented 1 year ago

Hi, thank you for the suggestions!

I put the config files into /etc with other daemons and not $XDG_CONFIG_HOME because unlike Barrier and others, rkvm runs system wide for all users.

The reason for having a preshared password is simply that I couldn't figure out if it's possible to have TLS client auth with rustls.

JPenuchot commented 1 year ago

Gotcha, thanks for clearing that out :)