Feature: Ignore duplicate URLs (optionally)

htrinter / Open-Multiple-URLs

Browser extension for opening lists of URLs built on top of WebExtension with cross-browser support

GNU General Public License v3.0

245 stars 56 forks source link

Feature: Ignore duplicate URLs (optionally) #65

Closed rokala closed 8 months ago

rokala commented 1 year ago

Adds an option to only open each unique URL once (ignore duplicates).
Extend 'tabcount' message to display amount of ignored URLs, if any.
Extend and adapt test suites to cover the new feature.
Trim whitespace around each line for improved matching of identical URLs.
Fixed minor bug I found in the index test suite.

See issue #58

PeterDaveHello commented 1 year ago

I wonder if this option can also applied on the "Extract URLs from text" feature, which means to deduplicate in the extraction process, that there will be only uniq URLs in the text box, would be really useful 😃

Forage commented 10 months ago

@PeterDaveHello I think the extraction feature should not depend on the state of the checkbox. It should always include/extract a URL only once.

PeterDaveHello commented 10 months ago

@Forage, it might or might not be, depending on the design philosophy of the tool's features. However, it seems that the development has been paused for now.

htrinter commented 8 months ago

Hi! Thank you for your contribution! Currently I am rewriting the app in Vue. I will have a look at the code and decide if I implement the feature in the rewrite. Deduplication as an option on loading the URLs makes sense.

htrinter commented 8 months ago

I implemented the feature on top of my refactoring branch. I created a pull request in case you've got time to take a look: https://github.com/htrinter/Open-Multiple-URLs/pull/76

rokala commented 8 months ago

@htrinter apologize for late answer, the PR looks good. This is a very handy extension and I'm glad I could contribute.