search

http-interop / http-middleware

PSR-15 interfaces for HTTP Middleware
MIT License
73 stars 7 forks source link

Rename Frame to Delegate #4

Closed shadowhand closed 8 years ago

shadowhand commented 8 years ago

Attempt to resolve confusion as to the purpose of the "next" caller.

shadowhand commented 8 years ago

@mnapoli @mindplay-dk is this enough to satisfy the immediate concern regarding the name of the "next middleware" dispatcher?

mindplay-dk commented 8 years ago

I still would go with full-on MiddlewareDelegateInterface to be explicit - I know it's longer, but should raise less questions ("delegate of what?") and it's not like we'll be typing that interface name all day? ;-)

shadowhand commented 8 years ago

@mindplay-dk not sure I agree the interface needs to be longer. The interface is clearly in the HTTP namespace and will only be used in a middleware.

mindplay-dk commented 8 years ago

The interface is clearly in the HTTP namespace and will only be used in a middleware.

Okay, good point.

mnapoli commented 8 years ago

Should the same change be reflected in PSR-15 and its meta document?

shadowhand commented 8 years ago

@mnapoli yes it should.

mnapoli commented 8 years ago

From your answer I didn't know if you already worked on it or planned to work on it, so … https://github.com/php-fig/fig-standards/pull/808

shadowhand commented 8 years ago

@mnapoli was planning on submitting a PR in the next 48 hours. Glad someone else took initiative. 😄